Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fields): add cursorHeight property for form builder text field #1112

Conversation

xetra11
Copy link
Contributor

@xetra11 xetra11 commented Sep 14, 2022

Connection with issue(s)

Close #719

Solution description

Simply added the delegation to TextField like cursorWidth. However I was not able to test this with the example project. There is some contribution documentation missing on how to build the package locally to use it in the example project.

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Collaborator

Hi!
Thanks for contribution
To build example, only need open the example project, get dependencies and run it

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1112 (8340231) into main (122fcd4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1112   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files          19       19           
  Lines         703      703           
=======================================
  Hits          502      502           
  Misses        201      201           
Impacted Files Coverage Δ
lib/src/fields/form_builder_text_field.dart 95.12% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit 9348c10 into flutter-form-builder-ecosystem:main Sep 14, 2022
@xetra11
Copy link
Contributor Author

xetra11 commented Sep 15, 2022

Hi! Thanks for contribution To build example, only need open the example project, get dependencies and run it

But just getting the dependency will only fetch the one published? Not the one I changed locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderTextField] Add property cursorHeight
2 participants