Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom iconed checkbox that can control its active, inactive and tristae icon #1131

Conversation

Siqlain-Hanif
Copy link

Connection with issue(s)

Close #???

Connected to #???

Solution description

Screenshots or Videos

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Collaborator

deandreamatias commented Oct 29, 2022

Hi @Siqlain-Hanif ! Thanks for your contribution!
I don't know if we can add this huge change.
I think that is create a funtionality for form field that does not add much worth and will be another thing to mantain.
If use a custom checkbox control can't be more simple, I think that solutions is that developers create your own form field with a custom control icon.

Sorry for this bad news, I thought that this feature will be more simple

@Siqlain-Hanif
Copy link
Author

This was huge change and main reason was that flutter checkbox uses painter to render the icon so extension to that is not possible for this use case. So i had to come up with the new widget that uses the same API as flutter checkbox but render icons differently so other default icons can be used.

I agree this will be one more thing to maintain.

But any way i had a need of this in my project, so all is good and also i will publish this as a package so other can use this as well, In case they have similar requirements.

@deandreamatias
Copy link
Collaborator

Thanks for understanding!
When you implement this, maybe can add some example in readme using your package.
So, with this conclusion, I will close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants