Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mouseCursor option to range and time picker to match other … #1282

Merged

Conversation

RyanCarrier
Copy link
Contributor

@RyanCarrier RyanCarrier commented Aug 23, 2023

Added optional parameter of mouseCursor to the date/time fields
The default FormBuilderTextField already has this

Connection with issue(s)

NA

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

@deandreamatias
Copy link
Collaborator

Hi @RyanCarrier
Thanks for contribution.
Please resolve issue on analysis static code (pipeline)

@RyanCarrier
Copy link
Contributor Author

Hey mate, the static lint was already in the code base, but I've added a temporary fix until dart 3.2 comes out. (and fast forwarded to latest main)

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1282 (babacea) into main (45998fc) will increase coverage by 0.02%.
Report is 4 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   84.94%   84.96%   +0.02%     
==========================================
  Files          21       21              
  Lines         724      725       +1     
==========================================
+ Hits          615      616       +1     
  Misses        109      109              
Files Changed Coverage Δ
lib/src/fields/form_builder_date_range_picker.dart 86.11% <ø> (ø)
lib/src/fields/form_builder_date_time_picker.dart 86.40% <33.33%> (+0.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deandreamatias deandreamatias merged commit c55499e into flutter-form-builder-ecosystem:main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants