Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass parameter keyboardType to material showDatePicker #1352

Merged

Conversation

Brunobnahorny
Copy link
Contributor

@Brunobnahorny Brunobnahorny commented Jan 18, 2024

Hello!

Close: #1351

We got some issues with users trying to edit the date in the material datepicker with Samsung Keyboard.
Sadly is a well known flutter issue,
flutter/flutter#62401

Solution description

The material datepicker allow to choose the keyboardType. Although it's not the best user experience, we want to set the keyboardType to text. The FormBuilderDateTimePicker receives the parameter put don't pass it for the material showDatePícker.

Screenshots or Videos

image

#1351
I opened the above issue to discuss the default value of FormBuilderDateTimePicker

To Do

  • Read contributing guide
  • Check the original issue to confirm it is fully satisfied
  • Add solution description to help guide reviewers
  • Add unit test to verify new or fixed behaviour
  • If apply, add documentation to code properties and package readme

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba065e5) 87.74% compared to head (7ea7743) 88.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1352      +/-   ##
==========================================
+ Coverage   87.74%   88.02%   +0.27%     
==========================================
  Files          21       21              
  Lines         759      760       +1     
==========================================
+ Hits          666      669       +3     
+ Misses         93       91       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deandreamatias deandreamatias merged commit 50f5645 into flutter-form-builder-ecosystem:main Jan 19, 2024
4 checks passed
@Brunobnahorny Brunobnahorny deleted the patch-1 branch February 1, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormBuilderDatePicker]: keyboardType is not passed to material showDatePicker
2 participants