Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example project #147

Merged
merged 1 commit into from
Oct 3, 2019
Merged

Fix example project #147

merged 1 commit into from
Oct 3, 2019

Conversation

prasadsunny1
Copy link
Contributor

  • Migrate to androidX.
  • Upgrade gradle version.
  • Update target android sdk

@prasadsunny1
Fix example project
caa66ea 
- Migrate to androidX.
- Upgrade gradle version.
- Update target android sdk
@danvick
Copy link
Collaborator

danvick commented Oct 3, 2019

Thanks for the PR, @prasadsunny1. You're the best.

@danvick danvick merged commit 52f45d9 into flutter-form-builder-ecosystem:master Oct 3, 2019
@prasadsunny1
Copy link
Contributor Author

Wow, my first PR.
Thanks for accepting.
BTW, love your project.

@prasadsunny1
Copy link
Contributor Author

Is it ok to pump up the Gradle version to the latest one?
(I don't understand android that well, expert advice? !!)

@danvick
Copy link
Collaborator

danvick commented Oct 3, 2019

This package doesn't rely on any android specific code, so it should be safe.
PS: I'm not an Android expert either. ;-)
Thanks for the love.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prasadsunny1 @danvick