Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade datetime_picker_formfield to 0.3.2 #93

Merged
merged 2 commits into from
Jul 17, 2019

Conversation

knaeckeKami
Copy link
Contributor

datetime_picker_formfield made some breaking changes, but introduced important bug fixes.
This PR updates to datetime_picker_formfield 0.3.2 and implement some changes to address these breaking changes without changing the API of this library; With one exception:
Since InputType was deleted from datetime_picker_formfield, I introduce a new enum InputType with the same values.

@danvick danvick merged commit a2caf8a into flutter-form-builder-ecosystem:master Jul 17, 2019
@danvick
Copy link
Collaborator

danvick commented Jul 17, 2019

Thanks for your contribution @knaeckeKami. Will review and publish as soon as I can.

@knaeckeKami
Copy link
Contributor Author

Thanks for the quick merging.
However, datetime_picker_formfield released a new version with another hotfix, and reverts some of the breaking changes. I will open a new PR.

@danvick
Copy link
Collaborator

danvick commented Jul 17, 2019

That'll be helpful. I've also realized that the current version you've added is using the new version v1.7 of Flutter which has breaking changes.

That'll also require that I work on making the whole package compatible with this version of Flutter.

@knaeckeKami
Copy link
Contributor Author

Oh, I'm already on (1.7.8+hotfix.3) so I didn't realize, sorry.
But for my use cases, flutter_form_builder with the new datetime_picker_formfield works without problems on flutter 1.7.8, I didn't notice any breaking changes. I didn't test if it still works on flutter 1.5.4.
Which problems do have have specifically?

@danvick
Copy link
Collaborator

danvick commented Jul 17, 2019

There was this issue reported by some individuals who did the upgrade recently.

Problem is that I cant easily switch between versions of Flutter, and I'm working on some work projects which aren't compatible with the v1.7.8

@knaeckeKami
Copy link
Contributor Author

I'm not sure if it's related to flutter 1.7.8. reset() works fine for me.

Would be nice to have a minimal sample where this bug occurs.

@danvick
Copy link
Collaborator

danvick commented Jul 17, 2019

If you could find time to assist in resolving the issue for them I'll appreciate, we can ask whoever raised the issue to give clarification.
I've also been unable to reproduce the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants