fix CameraUpdate.newLatLngBounds() applies incorrect padding on iOS #1039
Conversation
| bottom: paddingBottom, | ||
| right: paddingRight | ||
| ) | ||
| print(insets.top) |
| guard let type = cameraUpdate[0] as? String else { return } | ||
|
|
||
| if(type == "newLatLngBounds"){ | ||
| guard let bounds = cameraUpdate[1] as? [[Double]] else { return } |
There was a problem hiding this comment.
move this to a common function
|
please also run dart and swift formatting |
| LIBRARY_SEARCH_PATHS = ( | ||
| "$(inherited)", | ||
| "$(PROJECT_DIR)/Flutter", | ||
| ); | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.mapbox.mapboxGlExample; | ||
| PRODUCT_BUNDLE_IDENTIFIER = com.mapbox.mmapboxGlExample; |
There was a problem hiding this comment.
I'm not too familiar with iOS development, but this seems off?
And do we want the other changes to this file (specifically regarding code signing / development team) commited to the repo?
There was a problem hiding this comment.
Thanks for mentioning this @m0nac0 . i should revert back this line
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'll try to resolve conflicts and fix review issues this week |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@paulVulog you can also push the branch @easazade to your own fork and do the required changes to get this mergeable, and create a new PR |
fixes #1034