Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors #239

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Fix CI errors #239

merged 1 commit into from
Apr 2, 2020

Conversation

TimothySealy
Copy link
Collaborator

It seems that the CI is installing version 2.5.3 of the location package as opposed to version 2.3.5 which is specified in the pubspec.yaml. As of 2.5.0 there is a breaking change in the hasPermission method, it now returns an enum instead of a bool.

Also see: https://pub.dev/packages/location#-changelog-tab-

@TimothySealy TimothySealy requested a review from tobrun March 1, 2020 20:03
Copy link
Collaborator

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cdiaz
Copy link

cdiaz commented Mar 13, 2020

Please, merge this in master

@andrea689 andrea689 merged commit e352b22 into master Apr 2, 2020
andrea689 added a commit to andrea689/flutter-mapbox-gl that referenced this pull request Apr 2, 2020
* master:
  Updated location package and code to cope with a breaking change. (flutter-mapbox-gl#239)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants