Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add animation duration for animateCamera #259

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Apr 19, 2020

Needed that for my project, hope it can help you :)
I've tried to stay as close as possible to the Android naming convention.

@Lyokone Lyokone changed the title Add animation duration for animateCamera Add animation duration for animateCamera Apr 19, 2020
@m0nac0
Copy link
Collaborator

m0nac0 commented Apr 19, 2020

Thank you for the contribution!
I have just two suggestions:

  1. Could we use a dart Duration object and change the parameter name to 'duration'?
  2. Could you check why the iOS CI build fails? (I'm not an iOS dev, but it throws multiple errors)

@Lyokone
Copy link
Contributor Author

Lyokone commented Apr 19, 2020

Hey ! Sure i can modify it to a Duration object.
Not sure what's going on for the iOS part but I'm looking into it :)

@Lyokone
Copy link
Contributor Author

Lyokone commented Apr 19, 2020

Should be good now

Copy link
Collaborator

@m0nac0 m0nac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@m0nac0 m0nac0 merged commit b08dc32 into flutter-mapbox-gl:master Apr 19, 2020
andrea689 added a commit to andrea689/flutter-mapbox-gl that referenced this pull request Jun 3, 2020
* master:
  [flutter] release v0.6.0
  Change gradle version to 3.5.0 instead of 3.6.1
  Update Mapbox plugins and gradle
  iOS: add long press handler (flutter-mapbox-gl#268)
  [android] Implemented long click for Android (flutter-mapbox-gl#198)
  [fix] Change default MyLocationTrackingMode to None (flutter-mapbox-gl#285)
  Add First-Class Support For Listening to `onCameraIdle` events (flutter-mapbox-gl#280)
  CI: use stable flutter channel also on iOS (flutter-mapbox-gl#270)
  Implement addImage() to style (flutter-mapbox-gl#269)
  Add animation duration for animateCamera (flutter-mapbox-gl#259)
  Document onStyleLoadedCallback (flutter-mapbox-gl#257)
  example: rename Page to ExamplePage (flutter-mapbox-gl#258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants