Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leak caused by strong self reference #370

Merged
merged 1 commit into from
Oct 24, 2020
Merged

fix memory leak caused by strong self reference #370

merged 1 commit into from
Oct 24, 2020

Conversation

thirteenthstep
Copy link
Contributor

using a weak self reference will allow MapboxMapController to be deallocated

@thirteenthstep thirteenthstep mentioned this pull request Jul 31, 2020
Closed
@m0nac0 m0nac0 added the ios label Aug 15, 2020
@TimothySealy TimothySealy mentioned this pull request Aug 24, 2020
Closed
@AAverin AAverin mentioned this pull request Sep 5, 2020
Closed
@m0nac0
Copy link
Collaborator

m0nac0 commented Sep 6, 2020

@thirteenthstep Thank you for your contribution!

@tobrun @TimothySealy My iOS dev knowledge is too limited to appropriately review this change, but there seems to be a good chance it solves those memory leak issues on iOS. What do you think?

@AAverin
Copy link
Contributor

AAverin commented Sep 11, 2020

So testing this in my setup, leak is still there.
I have used the PR branch directly and I still have 2 instances of the map sitting in memory when there should be none.
It is important to note though that I am using AutomaticKeepAliveClientMixin

@thirteenthstep
Copy link
Contributor Author

Hi @AAverin,
this PR is meant to fix a memory leak which will occur in a "clean" environment. Multiple instances of MapboxMapController will be kept in memory every time it is used in iOS. This problem can be prevented by the suggested fix.
Unfortunately I do not know if the problems in your setup are related or not, but i suggest to merge - or further test - this PR regardless, since it will be an improvement at least.

@AAverin
Copy link
Contributor

AAverin commented Sep 14, 2020

@thirteenthstep PR makes sense, looking at the code, but I can't confirm if it fixes the problem. I would also recommend to merge it nevertheless

@tobrun tobrun merged commit c0492dc into flutter-mapbox-gl:master Oct 24, 2020
IcyTv added a commit to IcyTv/flutter-mapbox-gl that referenced this pull request Nov 15, 2020
@IcyTv @emowise
@emreyalcinnetcad @m0nac0 @tobrun @cuberob @qbouchat @TimothySealy @n8han @lcor-io @philiplindberg @thirteenthstep @GULERTOLGA @andrea689
Merged (#1)
34769d9 
* Expose CompassViewPosition flutter-mapbox-gl#344 (flutter-mapbox-gl#346)

Co-authored-by: emre.yalcin <emre.yalcin@netcad.com.tr>

* Readme: location features on Android (flutter-mapbox-gl#342)

* Update CONTRIBUTING.md (flutter-mapbox-gl#366)

* Release 0.8.0 (flutter-mapbox-gl#390)

* [release] update CHANGELOG.md for release of v0.8.0

* [release] update version numbers to v0.8.0

* Update CONTRIBUTING.md (flutter-mapbox-gl#401)

Fix stale pull, issues & changelog urls in the contributing guide.

* Fix data parameter for addLine and addCircle (flutter-mapbox-gl#388)

* Split padding values in CameraUpdate.newLatLngBounds() (flutter-mapbox-gl#382)

* Split padding values in CameraUpdate.newLatLngBounds()

* Remove old unused code

Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>

* Re-enable attribution on android (flutter-mapbox-gl#383)

* Upgrade Android annotation plugin to v0.9 (flutter-mapbox-gl#381)

* web: ignore myLocationTrackingMode if myLocationEnabled is false (flutter-mapbox-gl#363)

* Add methods to access projection (flutter-mapbox-gl#380)

* remove bitmap; add projection access

* Replace ScreenLocation with Point; expand iOS implementation

* fix iOS with guard let

* iOS: cast to NSObject

* fix typo

* round result of toScreenLocation()

* Revert "round result of toScreenLocation()"

This reverts commit 838726a.

* Docs: document rounding behaviour

* Add Fill API support (flutter-mapbox-gl#49)

* [flutter] [android] - add fill support

* Resolved merge conflict.

* A first working version for ios (after some extensive rebasing).

* Minor cleanup

* Minor cleanup.

* Fix broken build Android.

* A working version for Android.

* Minor cleanup.

* Added fill pattern example. Works on Android not on iOS. Seems to break consecutive fills though.

* For the first queried feature (when filter is set) create a fill.

* Fix lint issue (unused method).

* Updated code formatting.

* Added interior polygon to iOS.

* [docs] update readme support table

* fixup

Co-authored-by: Timothy Sealy <timothy.sealy@gmail.com>

* Listen to OnUserLocationUpdated to provide user location to app (flutter-mapbox-gl#237)

* Listen to OnUserLocationUpdated to provide user location to app

While the `myLocationEnabled` property is set to `true`, this method is
called whenever a new location update is received by the map view.

iOS only, needs Android. I did check that the location properties
carried here are also provided in Android's [Location][1] object.

[1]: https://developer.android.com/reference/android/location/Location

* add android, web; fix conflicts

Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>

* fix: correct bug on android where checking on activity lifecycles that were disposed (flutter-mapbox-gl#266)

Co-authored-by: leo cornillon <leo.cornillon.dev@gmail.com>
Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>

* Add support for custom font stack in symbol options (flutter-mapbox-gl#359)

* fix memory leak caused by strong self reference (flutter-mapbox-gl#370)

* Basic ImageSource Support (flutter-mapbox-gl#409)

* Introduce LatLngQuad

Introduce the LatLngQuad object which will be
useful to pass in all the required parameters
to the addSource() method we will define later.

* Introduce addSource() Method

Add the addSource(..) method to the mapbox_gl_platform_interface.dart

* Add addSource MethodChannel

* Place ImageSource Android

- Introduce the PlaceSource page as a playground
- Add 'addImageSource', 'removeImageSource', 'addLayer' & 'removeLayer' apis
- Implement Android platform interface

* iOS ImageSource Implementation

Implement addImageSource, removeImageSource, addLayer &
removeLayer on iOS.

* Fix iOS CoordinateQuad Mapping

Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>

* Get meters per pixel at latitude (flutter-mapbox-gl#416)

* fix git refferences

* fix git refferences

* implementation of getMetersPerPixelAtLatitude

* getMetersPerPixelAtLatitude

* fix refference paths

* Android implementation and Example updated.

* added comments to getMetersPerPixelAtLatitude method

* IOS implementation

* Removed modified lines from pubspec.yaml files

* web implementation

Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>

* fix onStyleLoadedCallback (flutter-mapbox-gl#418)

* fix onStyleLoadedCallback

* fix onStyleLoadedCallback called before onMapCreated

Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>

* Release 0.9.0

* update version numbers for v0.9.0 release

* fix ios onSymbolTapped

Co-authored-by: emreuguryalcintr <50848628+emreuguryalcintr@users.noreply.github.com>
Co-authored-by: emre.yalcin <emre.yalcin@netcad.com.tr>
Co-authored-by: m0nac0 <58807793+m0nac0@users.noreply.github.com>
Co-authored-by: Tobrun <tobrun.van.nuland@gmail.com>
Co-authored-by: cuberob <robdeknegt@gmail.com>
Co-authored-by: qbouchat <48958612+qbouchat@users.noreply.github.com>
Co-authored-by: Timothy Sealy <timothy.sealy@gmail.com>
Co-authored-by: Nathan <nathan@transit.app>
Co-authored-by: Leo Cornillon <corle.cugly@gmail.com>
Co-authored-by: leo cornillon <leo.cornillon.dev@gmail.com>
Co-authored-by: Philip Lindberg <philip.c.lindberg@gmail.com>
Co-authored-by: Thomas Kröniger <30893720+thirteenthstep@users.noreply.github.com>
Co-authored-by: cuberob <git@cuberob.com>
Co-authored-by: GULERTOLGA <gulertolga@gmail.com>
Co-authored-by: Andrea Valenzano <andr3a689@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammamark cammamark cammamark approved these changes

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thirteenthstep @m0nac0 @AAverin @tobrun @cammamark