Full source support

[felix-ht]

I'm currently working on fully supporting all types of sources. Related to #758.
Doing this now because i started to look at adding raster layer and doing this without code gen seemed like a bad idea, so i might as well go all the way.

This includes supporting everything in the style spec with relation to sources

• vector
• raster
• raster_dem
• geojson
• video
• image

This will also add support for clustering, as this is part of the source spec. #752

Todo:

• basic code gen for dart
  - [ ] better code gen for dart (required args - args that are not nullable)
• web implementation
• ios implementation
• android implementation

This will take some to until it lands (as im not working full-time on this, but should be this year), but I wanted to add this early as a draft. Most of the code is subject to change. So feel free to take a look, but no need to review as of now.

[kamami]

How's it going? Very interested in those features!

[felix-ht]

might be able to work on this next week - let's see

[kamami]

That would be awesome!

[tobrun]

you are a gem @felix-ht, let me know if you want to divide the work, happy to help out

[felix-ht]

I added a working example for the web version - Various Sources. This currently shows geojson (with clustering) vector and raster sources.

[felix-ht]

So iOS Android and web are now able to show all sources, and working as expected.

One thing currently still missing is the option to add an image as raw bytes. This is not part of the normal style spec, and also not supported on web. So im not sure if i should even add it. Might be more elegant to rely on local - (file) uris to load assets? @tobrun

I will do some cleanup besides that and remove the draft status afterwards.

[tobrun]

amazing work @felix-ht

[kamami]

Great! Now we only need some proper examples and guides, on how to achieve e.g. clustering with this plugin :D

[felix-ht]

@kamami there are pretty decent examples for all source types (and clustering) examples in example/lib/sources.dart

[laudaget]

@felix-ht I cant figure out how to style the none clustered points like in the example given for android:

https://docs.mapbox.com/ios/legacy/maps/examples/clustering/?q=attribution&size=n_10_n

Is there something similiar to predicates? Or am i missing something out? Thank you!

[felix-ht]

@laudaget layers currently don't support filtering - so no. Please create a separate ticket for this tho.

[AAverin]

@felix-ht I am now exploring this new feature and implement clustering in my app.
Is there setSource similar to how we have setGeoJsonSource?
Or what is the workflow exactly?

I have tried removing the source because I have points changing for clustering when camera moves, but got an error Source 'spots' is in use, cannot remove and then PlatformException and crash with CannotAddSourceException: Source spots already exists when adding.

[AAverin]

Removing all layers first helped, but probably setSource and keeping all the layers would be better. If I have added source like

 await _mapController?.addSource(
          "spots",
          GeojsonSourceProperties(
              data: vm!.spotsGeoJson,
              cluster: true,
              clusterMaxZoom: 14, // Max zoom to cluster points on
              clusterRadius:
                  50 // Radius of each cluster when clustering points (defaults to 50)
              ));

Is it safe then later to call setGeoJsonSource? Would it just update the data for the source in geojson format?
What about SourceOptions?

[felix-ht]

Removing all layers first helped, but probably setSource and keeping all the layers would be better. If I have added source like

 await _mapController?.addSource(
          "spots",
          GeojsonSourceProperties(
              data: vm!.spotsGeoJson,
              cluster: true,
              clusterMaxZoom: 14, // Max zoom to cluster points on
              clusterRadius:
                  50 // Radius of each cluster when clustering points (defaults to 50)
              ));

Is it safe then later to call setGeoJsonSource? Would it just update the data for the source in geojson format? What about SourceOptions?

yes that should be save - as far as i know. I will only change the geojson data - the options should remain untouched.