Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add java formatting #863

Merged
merged 2 commits into from
Jan 18, 2022
Merged

add java formatting #863

merged 2 commits into from
Jan 18, 2022

Conversation

felix-ht
Copy link
Collaborator

Added java formatting based on https://github.com/google/google-java-format

Java part of #818

@felix-ht felix-ht had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN January 17, 2022 15:58 Failure
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN January 17, 2022 15:58 Inactive
@felix-ht felix-ht had a problem deploying to ANDROID_CI_DOWNLOADS_TOKEN January 17, 2022 16:00 Failure
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN January 17, 2022 16:00 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN January 18, 2022 09:21 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN January 18, 2022 09:21 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN January 18, 2022 16:32 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN January 18, 2022 16:32 Inactive
@felix-ht felix-ht requested a review from m0nac0 January 18, 2022 16:34
@felix-ht felix-ht marked this pull request as ready for review January 18, 2022 16:34
@felix-ht
Copy link
Collaborator Author

I changes to the java files are pure formatting changes.

m0nac0
m0nac0 approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@m0nac0 m0nac0 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Something I just thought about: we might want to document the code styles we are using for the different languages in CONTRIBUTING.md

@felix-ht
Copy link
Collaborator Author

@m0nac0 great idea!

@felix-ht felix-ht merged commit e270a1a into master Jan 18, 2022
@felix-ht felix-ht deleted the java-format branch January 18, 2022 19:46
@m0nac0 m0nac0 mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m0nac0 m0nac0 m0nac0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felix-ht @m0nac0