fixed issue with map disposal on web #895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should also fix #639 |
AAverin
approved these changes
Feb 4, 2022
|
@AAverin yeah thats why i added you as well. And thanks for the review! |
|
note that the android build failed. This is however not related to this pr and almost certainly caused by the release of flutter 2.10. So i went forward with the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes after a map has been disposed by the framework, one of two things would happen:
a callback (e.g. cameraMoved) was called after the controller has been disposed - causing an error as it tried to notifyListeners after a disposal.
the map would try to redraw after the canvas had been disposed - this would fully crash the web app.
To fix this i removed all callback from within the controller on disposal (this should also allow the GC to collect it) and the web platform plugin now also properly releases all resources avoiding redraws.