Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement layer filtering #997

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Implement layer filtering #997

merged 1 commit into from
Apr 25, 2022

Conversation

morvagergely
Copy link
Contributor

Closes #796.

@yannis216
Copy link

Oh we need this desperately, very nice!

felix-ht
felix-ht requested changes Apr 11, 2022
View reviewed changes
ios/Classes/MapboxMapController.swift Outdated Show resolved Hide resolved
@felix-ht
Copy link
Collaborator

it would also be nice if one could pass filters while adding a new layer - no need for two operations. Most of the code you have right now can be reused for that

@morvagergely
Copy link
Contributor Author

it would also be nice if one could pass filters while adding a new layer - no need for two operations. Most of the code you have right now can be reused for that

I think it could be done in a different PR. I will probably be able to do it next week.

felix-ht
felix-ht previously approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@felix-ht felix-ht left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN April 11, 2022 09:56 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN April 11, 2022 09:56 Inactive
@felix-ht felix-ht dismissed their stale review April 11, 2022 09:59

missed formatting

@felix-ht
Copy link
Collaborator

please run the java formatting with

 java \  
  --add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \
  --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED \
  -jar google-java-format-1.13.0-all-deps.jar -i $(find . -type f -name "*.java")

@skreborn
Copy link

@felix-ht Is there anything else that needs to get done before this is merged?

@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN April 25, 2022 12:59 Inactive
@felix-ht felix-ht temporarily deployed to ANDROID_CI_DOWNLOADS_TOKEN April 25, 2022 12:59 Inactive
felix-ht
felix-ht approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@felix-ht felix-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felix-ht felix-ht merged commit b1f2392 into flutter-mapbox-gl:master Apr 25, 2022
This was referenced Apr 28, 2022
Closed
Merged
FreeGrow added a commit to FreeGrow/maps that referenced this pull request Sep 21, 2023
@FreeGrow
Revert "Implement layer filtering (flutter-mapbox-gl#997)"
84aeab9 
This reverts commit b1f2392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-ht felix-ht felix-ht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to show different types of features without creating a new Style?
4 participants
@morvagergely @yannis216 @felix-ht @skreborn