Embed ICU data in the engine #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I touch the icu data before (if not using only English...), it always cause a problem... Do you know what |
bwikbs
approved these changes
Feb 4, 2021
|
I'll set this as draft and do some more testing when the font resolution issue is resolved. |
|
I found another workaround. I'll open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the total app size by 10 MB. The original ICU data size is 11 MB (
icudtl.dat) and it's 0.9 MB (icudtl.o) after object copy.The
icudtl_objectaction was copied from//shell/platform/android/BUILD.gn.