forked from flutter/engine
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TextInputChannel to supprot platform view #52
Merged
bbrto21
merged 1 commit into
flutter-tizen:flutter-2.0.1-tizen
from
seungsoo47:imf_webview2
Mar 22, 2021
Merged
Update TextInputChannel to supprot platform view #52
bbrto21
merged 1 commit into
flutter-tizen:flutter-2.0.1-tizen
from
seungsoo47:imf_webview2
Mar 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
approved these changes
Mar 19, 2021
bbrto21
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
swift-kim
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Current the text input channel handles user input for only existing flutter components. Therefore, we added the logic so that the platform view can also handle the composition events happened by user input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Therefore, we added the logic so that the platform view can also handle the composition
events happened by user input.