-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable arm64 build #63
Conversation
I chose a profile factor of 0.5 for kCommon because it just looked good on my monitor. Actually the Tizen system info returns a dpi value of 210 which is larger than expected (around 91). I don't know how to choose a right value. Texts might be too small on higher dpi monitors. |
Note that you need to update the toolchain (https://github.com/flutter-tizen/tizen_tools/pull/7) to build for arm64. |
I've tried building it and found 2 fails (maybe my environment is affecting it).
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ecore_imf_context_client_window_set( | ||
imf_context_, (void*)engine_->tizen_renderer->GetEcoreWindowId()); | ||
imf_context_, | ||
(void*)(intptr_t)(engine_->tizen_renderer->GetEcoreWindowId())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks better than I mentioned before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can now confirm that this change works.
The second issue was my mistake - I didn't have this PR applied to repo cloned by gclient. After fixing that I was able to compile and run a flutter app on 64bit Tizen IoT.
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
…lock. (#63) Also fixes the files with missing licenses. This check is somewhat easy with Impeller than in the engine because all source files must have the same license block. Resolves an action item in the umbrella issue flutter/flutter#97686.
* Enable arm64 build * Update azure-pipelines.yml * Add the common profile
build_engine_artifacts
to false since we're cross-building on x64 (we don't need SDK artifacts)azure-pipelines.yaml
for continuous integration