- 
                Notifications
    
You must be signed in to change notification settings  - Fork 52
 
[webview_flutter] Refactor the C++ code #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webview_flutter] Refactor the C++ code #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think it's good.
| 
           @seungsoo47 @bwikbs @JSUYA @Swanseo0  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with the overall direction. I'm happy with this refactoring.
Thanks. 👍
84f34de    to
    e457f49      
    Compare
  
    
Part of the code refactoring project.
BufferUnitandBufferPool:BufferUnit::Index.BufferUnit::IsUsedandBufferUnit::GpuBuffer).WebView:params(constructor argument) toEncodableValueto reuse theGetValueFromEncodableMapfunction.RequestErrorTypetoResourceErrorType.NeedsSwBackendtoIsRunningOnEmulator.texture_variant_a unique pointer.HandleMethodCallalways send a result. (Fixes ImproveHandleMethodCallmethod not to return without sending a result. #376.)DispatchKeyDownEventandDispatchKeyUpEventbecauseHidePanelis no longer used."Select"has been added toKeyNameToKeyValuewithKeyValue::EnterKeyas a return value.WebViewFactory:textureRegistrarfrom constructor arguments. It can be taken fromregistrar.GetAppDataPathas a function.Other changes not listed in the above are style and readability fixes that are quite straightforward.