[FIX] Duplicated call onAnswer. New open method. #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efraespada
changed the title
|
Not merged yet |
ejimenez93
pushed a commit
to Griot-Inc/callkeep
that referenced
this pull request
Sep 9, 2021
commit dd1c872 Author: Efra Espada <efraespada@gmail.com> Date: Wed Sep 8 12:23:41 2021 +0200 [FIX] Duplicated call onAnswer. New open method. (flutter-webrtc#111) * feature: open method openPhoneAccounts * feature: fixed duplicated call onAnswer on VoiceConnection * feature: added support for drawables in notification icon in foreground service
ejimenez93
pushed a commit
to Griot-Inc/callkeep
that referenced
this pull request
Sep 9, 2021
…#1) * feature: open method openPhoneAccounts * feature: fixed duplicated call onAnswer on VoiceConnection * feature: added support for drawables in notification icon in foreground service Co-authored-by: Efra Espada <efraespada@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onAnswer.But the
void onAnswer(int videoState)method (inVoiceConnection) stills being invoked twice. Before this change,CallKeepPerformAnswerCallActionwas called x4.drawableicons for the foreground service's notification: