Extracting UI responsibility, named parameters, android dismissal fix #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three main fixes:
Android calling UI wasn't being dismissed when answerIncomingCall() was being called from in app UI.
needed to call setCurrent() in native android.
I spent ages trying to figure out why things weren't working only to realise i was passing the caller name into the handle parameter. Added named parameters to all functions so that shouldnt happen for anyone in the future and things are clearer.
In recent versions of flutter the framekwork suggest against passing BuildContexts across async gaps also your app should be responsible for how it looks not an external package. For the default permissions UI i've extracted out the responsibility so the app using the package can determine how that dialog looks.
Also some updates to the readme!