Skip to content

FontFeature diagrams #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hixie merged 3 commits into from
Jan 21, 2021
Merged

FontFeature diagrams #131

Hixie merged 3 commits into from
Jan 21, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 15, 2021

Adds a bunch of samples for FontFeature.

Hixie added 2 commits January 15, 2021 14:06
@Hixie
FontFeature diagrams
b817f37 
Adds a bunch of samples for FontFeature.
@Hixie
new assets
3d54b8a
@google-cla google-cla bot added the cla: yes label Jan 15, 2021
Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 16, 2021
@Hixie
Continue filling in the list of FontFeatures
59e7678 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
@Hixie Hixie mentioned this pull request Jan 16, 2021
Merged
@Hixie
Copy link
Contributor Author

Hixie commented Jan 16, 2021

See flutter/engine#23730 for what these document.

@Hixie
Copy link
Contributor Author

Hixie commented Jan 19, 2021

cc @GaryQian

Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 19, 2021
@Hixie
Continue filling in the list of FontFeatures
16d8ba0 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 20, 2021
@Hixie
Continue filling in the list of FontFeatures
84faa06 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
GaryQian
GaryQian reviewed Jan 21, 2021
View reviewed changes
utils/diagram_generator/lib/main.dart
final List<String> categories = flags['category'] as List<String>;
final List<String> names = flags['name'] as List<String>;

print('Filters:\n categories: $categories\n names: $names');
Copy link
Contributor

@GaryQian GaryQian Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Was this meant to be for debug or actually included here?

Copy link
Contributor Author

@Hixie Hixie Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intended to stay. The generator is really only run by us, so it's useful to see what it's doing. Previously we didn't report what filters we applied. (This is especially helpful on Linux where we don't currently handle arguments so the filters you specify on the command line don't actually apply and previously that was very confusing.)

GaryQian
GaryQian reviewed Jan 21, 2021
View reviewed changes
utils/diagram_generator/pubspec.yaml

- family: Ubuntu Mono
fonts:
- asset: fonts/UbuntuMono-Bold.ttf
Copy link
Contributor

@GaryQian GaryQian Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit trailing newline

Copy link
Contributor Author

@Hixie Hixie Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, fixed

GaryQian
GaryQian approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks really comprehensive!

@Hixie
Copy link
Contributor Author

Hixie commented Jan 21, 2021

Thanks, will land on green.

Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 21, 2021
@Hixie
Continue filling in the list of FontFeatures
f33bc7c 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
@Hixie Hixie merged commit 50fe0fc into flutter:master Jan 21, 2021
@Hixie Hixie deleted the font-feature branch January 21, 2021 22:38
Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 21, 2021
@Hixie
Continue filling in the list of FontFeatures
8dbb697 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 24, 2021
@Hixie
Continue filling in the list of FontFeatures
c346cc5 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
Hixie added a commit to Hixie/sky_engine that referenced this pull request Jan 26, 2021
@Hixie
Continue filling in the list of FontFeatures
07b2186 
This adds support and documentation for:

 * FontFeature.alternative(n)
 * FontFeature.alternativeFractions()
 * FontFeature.contextualAlternates()
 * FontFeature.caseSensitiveForms()
 * FontFeature.characterVariant(v)
 * FontFeature.denominator()
 * FontFeature.fractions()
 * FontFeature.historicalForms()
 * FontFeature.historicalLigatures()
 * FontFeature.liningFigures()
 * FontFeature.localeAware(enable: false)
 * FontFeature.notationalForms(v)
 * FontFeature.numerators()
 * FontFeature.oldstyleFigures()
 * FontFeature.ordinalForms()
 * FontFeature.proportionalFigures()
 * FontFeature.randomize() (minor additions to documentation)
 * FontFeature.stylisticAlternates()
 * FontFeature.scientificInferiors()
 * FontFeature.stylisticSet(n) (documentation)
 * FontFeature.subscripts()
 * FontFeature.superscripts()
 * FontFeature.swash(v)
 * FontFeature.tabularFigures() (documentation)
 * FontFeature.slashedZero()

There's hundreds more we could add but this is what I have so far.

See flutter/assets-for-api-docs#131 for the diagrams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hixie @GaryQian