This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Don't generate zx fidl headers and source. #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akbiggs
approved these changes
Jan 13, 2022
| parser.add_argument('--root', dest='root', action='store', required=True) | ||
| parser.add_argument('--json', dest='json', action='store', required=True) | ||
| parser.add_argument('--fidlgen-root', dest='fidlgen_root', action='store', required=True) | ||
| parser.add_argument('--fidlgen-output-root', dest='fidlgen_output_root', action='store', required=False) |
Contributor
There was a problem hiding this comment.
No action required, but it seems weird that fidlgen_bin is always required even though it won't be used when fidlgen_output_root is not set.
Contributor
Author
There was a problem hiding this comment.
noted. I've changed the code to consider this.
This is necessary to avoid name collisions. See flutter#542.
chaselatta
approved these changes
Jan 13, 2022
chandarrengoog
added a commit
to chandarrengoog/engine
that referenced
this pull request
Jan 13, 2022
chandarrengoog
added a commit
to flutter/engine
that referenced
this pull request
Jan 13, 2022
JsouLiang
pushed a commit
to JsouLiang/engine
that referenced
this pull request
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to avoid name collisions.
See #542.