Increase minimum macOS SDK from 10.13 to 10.14 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the minimum macOS SDK and the macOS deployment target from 10.13 to 10.14. Also enables aligned allocations on macOS. We previously set `-fno-aligned-allocation` on macOS since it was unsupported for arm64 prior to macOS 10.14. Issue: flutter/flutter#114445
knopp
approved these changes
Nov 7, 2022
8 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Nov 7, 2022
Includes: * Increase minimum macOS SDK from 10.13 to 10.14 (flutter/buildroot#648) Issue: flutter/flutter#114445
Closed
9 tasks
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Nov 8, 2022
In flutter/buildroot#648 (rolled to the engine in flutter#37380) the minimum macOS SDK was bumped from 10.13 to 10.14. As of macOS 10.14, Metal is available for all users. This eliminates the macOS OpenGL rendering support code. Note that this only removes the GL-specific code in the embedder. A followup patch will land refactorings to clean up the remaining code, for example, cases where a parent interface exists only because we had both a GL and a Metal implementation. This is being does in two patches in order to keep review clear and simple and to simplify rebases of any outstanding patches that also touches this code. Issue: flutter/flutter#114445
8 tasks
knopp
pushed a commit
to flutter/engine
that referenced
this pull request
Nov 9, 2022
In flutter/buildroot#648 (rolled to the engine in #37380) the minimum macOS SDK was bumped from 10.13 to 10.14. As of macOS 10.14, Metal is available for all users. This eliminates the macOS OpenGL rendering support code. Note that this only removes the GL-specific code in the embedder. A followup patch will land refactorings to clean up the remaining code, for example, cases where a parent interface exists only because we had both a GL and a Metal implementation. This is being does in two patches in order to keep review clear and simple and to simplify rebases of any outstanding patches that also touches this code. Issue: flutter/flutter#114445
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Nov 9, 2022
In flutter/buildroot#648 (rolled to the engine in flutter#37380) the minimum macOS SDK was bumped from 10.13 to 10.14. As of macOS 10.14, Metal is available for all users. This eliminates the macOS OpenGL rendering support code. Note that this only removes the GL-specific code in the embedder. A followup patch will land refactorings to clean up the remaining code, for example, cases where a parent interface exists only because we had both a GL and a Metal implementation. This is being does in two patches in order to keep review clear and simple and to simplify rebases of any outstanding patches that also touches this code. Issue: flutter/flutter#114445
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
In flutter/buildroot#648 (rolled to the engine in flutter#37380) the minimum macOS SDK was bumped from 10.13 to 10.14. As of macOS 10.14, Metal is available for all users. This eliminates the macOS OpenGL rendering support code. Note that this only removes the GL-specific code in the embedder. A followup patch will land refactorings to clean up the remaining code, for example, cases where a parent interface exists only because we had both a GL and a Metal implementation. This is being does in two patches in order to keep review clear and simple and to simplify rebases of any outstanding patches that also touches this code. Issue: flutter/flutter#114445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the minimum macOS SDK and the macOS deployment target from 10.13 to 10.14.
Also enables aligned allocations on macOS. We previously set
-fno-aligned-allocationon macOS since it was unsupported for arm64 prior to macOS 10.14.Issue: flutter/flutter#114445
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.