Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@loic-sharma
Copy link
Member

@loic-sharma loic-sharma commented Jan 20, 2023

Our tests depend on the Xcb and Wayland Vulkan extensions that are provided by SwiftShader. The latest version of SwiftShader now requires you to opt-in to these extensions through build flags: https://github.com/google/swiftshader/blob/aae98adc2222dcada4aa952cccad48ab08e34004/src/WSI/BUILD.gn#L39-L56

See: flutter/engine#38650

Part of: flutter/flutter#117932

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@loic-sharma loic-sharma changed the title [WIP] Update build configs for ANGLE, vulkan-deps, and SwiftShader roll Update build configs for ANGLE, vulkan-deps, and SwiftShader roll Jan 23, 2023
@loic-sharma loic-sharma marked this pull request as ready for review January 23, 2023 23:08
@loic-sharma loic-sharma merged commit d01da27 into flutter:master Jan 24, 2023
@loic-sharma loic-sharma deleted the roll-angle branch January 24, 2023 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants