Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding approval of the revert request #2089

Merged
merged 5 commits into from
Aug 26, 2022

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Aug 26, 2022

Description

Forgot to add auto-approval of the request. Since right now it will be validated correctly but we cannot merge due to the repository approval rules.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App. label Aug 26, 2022
@auto-submit auto-submit bot merged commit a95207a into flutter:main Aug 26, 2022
@ricardoamador ricardoamador deleted the approve_revert_fix branch August 26, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants