Skip to content

Teach comment analysis about gradle/groovy comments #2737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
May 15, 2023
Merged

Teach comment analysis about gradle/groovy comments #2737

auto-submit merged 2 commits into from
May 15, 2023

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented May 15, 2023 •
edited
Loading

flutter/flutter#126825

  • Add gradle and groovy to the extensions understood by the comment excluder for test exempt then add tests for all languages

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@reidbaker
Add gradle and groovy to the extentions understood by the comment exc…
8026088 
…luder for test exempt then add tests for all languages
@reidbaker reidbaker requested review from CaseyHillers, gmackall and ricardoamador and removed request for CaseyHillers May 15, 2023 14:25
@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App. label May 15, 2023
@auto-submit auto-submit bot merged commit 7598321 into flutter:main May 15, 2023
@reidbaker reidbaker deleted the i126825-teach-about-gradle-comments branch May 22, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ricardoamador ricardoamador Awaiting requested review from ricardoamador

@gmackall gmackall Awaiting requested review from gmackall

1 more reviewer

@CaseyHillers CaseyHillers CaseyHillers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@reidbaker @CaseyHillers