Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reschedule presubmit targets when base ref is changed #3211

Merged
merged 24 commits into from
Nov 17, 2023

Conversation

ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Nov 6, 2023

When the base reference is automatically switched we now rescheduler the try targets so it does not have to be done manually.

List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#137776

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dependabot bot and others added 18 commits June 1, 2023 19:16
Bumps [retry](https://github.com/google/dart-neats) from 3.1.1 to 3.1.2.
- [Commits](google/dart-neats@retry-3.1.1...retry-v3.1.2)

---
updated-dependencies:
- dependency-name: retry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github](https://github.com/SpinlockLabs/github.dart) from 9.18.0 to 9.19.0.
- [Release notes](https://github.com/SpinlockLabs/github.dart/releases)
- [Changelog](https://github.com/SpinlockLabs/github.dart/blob/master/CHANGELOG.md)
- [Commits](SpinlockLabs/github.dart@9.18.0...9.19.0)

---
updated-dependencies:
- dependency-name: github
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [test](https://github.com/dart-lang/test/tree/master/pkgs) from 1.24.6 to 1.24.7.
- [Release notes](https://github.com/dart-lang/test/releases)
- [Commits](https://github.com/dart-lang/test/commits/test-v1.24.7/pkgs)

---
updated-dependencies:
- dependency-name: test
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…try-3.1.2

Bump retry from 3.1.1 to 3.1.2 in /app_dart
…thub-9.19.0

Bump github from 9.18.0 to 9.19.0 in /app_dart
…/test-1.24.7

Bump test from 1.24.6 to 1.24.7 in /auto_submit
@ricardoamador
Copy link
Contributor Author

ricardoamador commented Nov 17, 2023

@CaseyHillers Friendly ping!
Disregard. I forgot about changes I need to add to the test.

@ricardoamador
Copy link
Contributor Author

ricardoamador commented Nov 17, 2023

@CaseyHillers okay, this is ready when you have a chance.

Copy link
Contributor

@CaseyHillers CaseyHillers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flutter-lgtm

Thanks for the fix, this will help on the release PRs and whenever we do the next master->main migration!

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App. label Nov 17, 2023
@auto-submit auto-submit bot merged commit 65bba15 into flutter:main Nov 17, 2023
4 checks passed
@ricardoamador ricardoamador deleted the reschedule_presubs_137776 branch February 5, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cocoon scheduler should reschedule presubmit tasks when base ref changes
4 participants