ffigen_codelab: Add step_07

[domesticmouse]

Pre-launch Checklist

• I read the Effective Dart: Style recently, and have followed its advice.
• I signed the CLA.
• I updated/added relevant documentation (doc comments with ///).
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

[domesticmouse]

PTAL @maks

Btw, you'll be amused to learn that the Duktape integration is breaking on Windows. I'm pretty certain I had it working, but I've got no idea how I broke it. Sigh.

[maks]

Looks great @domesticmouse ! Builds and runs fine on Ubuntu for me:

And looking at the last CI run looks like you solved the windows issue?

One small thing is that I think src/CMakeLists.txt has a typo on line 14?

[domesticmouse]

Nah, I haven't added tests. 😝

[domesticmouse]

@maks added a test and I have no idea how to make the test code load the library. Any ideas?

[maks]

@domesticmouse Hmm good question! I have an idea, let me have a quick go to see if it will work...

[maks]

@domesticmouse ok I got a quick unit test working here for me: maks@569fb6d

using the tip from dart-archive/ffi#39 (comment)

My quick hack is only for Linux so it will need to be generalised for the diff paths if you want to test on all OS's.

I'm also not sure why it doesn't seem to work for widget tests, but maybe for widget tests it would be better to not use the real native lib, ie. to have a riverpod provider for the native lib and then in the widgettests use a providerscope override to supply a fake provider?

[domesticmouse]

@domesticmouse ok I got a quick unit test working here for me: maks@569fb6d

using the tip from dart-archive/ffi#39 (comment)

My quick hack is only for Linux so it will need to be generalised for the diff paths if you want to test on all OS's.

Thank you @maks 🤓

I'm also not sure why it doesn't seem to work for widget tests, but maybe for widget tests it would be better to not use the real native lib, ie. to have a riverpod provider for the native lib and then in the widgettests use a providerscope override to supply a fake provider?

For this codelab, testing the FFI is the point 😎

[maks]

For this codelab, testing the FFI is the point sunglasses

Yes of course, sorry testing with the plugin in a Flutter widget test is the important part! 👍🏻
I can see you spotted the issue with the widget test was just the string matching, doh! sorry I should have spotted that too.

[domesticmouse]

Inspecting the generated DLL files with DLL Export Viewer, I'm seeing the DLL generated in Step 3 has appropriate exported entry points, yet the one in step 5 has nothing exported. I have vague recollections that windows requires something specific to export DLL entries?

[domesticmouse]

Status summary:

• Example is complete - JavaScript REPL and has been tested on Windows, macOS, Linux, iOS and Android.
• Example includes minimal smoke test to prove library integration. Works locally on macOS, Windows, Linux
• GitHub Action CI is passing the smoke test on macOS and Windows, but failing Linux
• GitHub Action Linux CI can't run flutter build linux --debug which is required to build the Duktape C library.

[domesticmouse]

@godofredoc Any ideas on how I can integrate the appropriate GitHub actions to install the required tooling to make compiling the Flutter linux app work?

[maks]

@godofredoc Any ideas on how I can integrate the appropriate GitHub actions to install the required tooling to make compiling the Flutter linux app work?

sorry to butt in here @domesticmouse but could you perhaps add a script step that does sudo apt install ninja-build ?

[domesticmouse]

sorry to butt in here @domesticmouse but could you perhaps add a script step that does sudo apt install ninja-build ?

Good call, that worked

[domesticmouse]

PTAL @RedBrogdon

I need to land this to complete the codelab write up.

[RedBrogdon]

LGTM. Is there anything we need to do with the Duktape license other than make sure it's included?

[domesticmouse]

LGTM. Is there anything we need to do with the Duktape license other than make sure it's included?

Duktape is MIT licensed (https://github.com/svaarala/duktape/blob/master/LICENSE.txt). Should we add a licenses section to the App UI?