Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old wiki link #2205

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Update old wiki link #2205

merged 1 commit into from
Jun 2, 2024

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Jun 1, 2024

Part of flutter/flutter#145009

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Do consider linking to main instead since it contains the mirrored content and will hopefully be the default in the future, while avoiding the need to update it again.

@Piinks
Copy link
Contributor Author

Piinks commented Jun 2, 2024

Thanks for the review!

Do consider linking to main instead since it contains the mirrored content and will hopefully be the default in the future, while avoiding the need to update it again.

I wanted to, but in the past it has confused folks that want to contribute. They'll send PRs to the main branch instead of master, where we are still anchored. However, this is a bit duplicitous since flutter/flutter's analyzer script checks against links containing master. 🙃

I do hope we switch fully over to main. I would really prefer it.

@Piinks Piinks merged commit 9fb3fa0 into flutter:main Jun 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants