Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make animations maintainable #2262

Merged

Conversation

domesticmouse
Copy link
Contributor

@domesticmouse domesticmouse commented Nov 20, 2024

Land with cl/699849063

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse marked this pull request as draft November 20, 2024 00:25
@johnpryan
Copy link
Contributor

Oops, I didn't realize this wasn't maintainable, do we have any resources to help avoid mistakes in the future?

@domesticmouse
Copy link
Contributor Author

The pattern you adopted makes total sense for development. I'm moving things around to make it easier for me to update all the codelabs during the Dart 3.7 reformat.

I'm just happy you found a way to build this codelab out on the tight timeline that you did.

@domesticmouse domesticmouse marked this pull request as ready for review November 26, 2024 04:00
@domesticmouse
Copy link
Contributor Author

Googlers: This PR matches cl/699849063

@domesticmouse
Copy link
Contributor Author

PTAL @johnpryan

@domesticmouse domesticmouse merged commit b31bf98 into flutter:main Dec 3, 2024
10 checks passed
@domesticmouse domesticmouse deleted the make-`animations`-maintainable branch December 3, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants