Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intro to flutter_gpu #2265

Merged
merged 17 commits into from
Dec 4, 2024
Merged

Add Intro to flutter_gpu #2265

merged 17 commits into from
Dec 4, 2024

Conversation

domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

bdero
bdero approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My browser had substantial trouble rendering the diff tab, but I pulled this down and the steps LGTM. Noticed that the last step is Scene as well. :)

@domesticmouse
Copy link
Contributor Author

My browser had substantial trouble rendering the diff tab, but I pulled this down and the steps LGTM. Noticed that the last step is Scene as well. :)

Yup, the last step is very much a bonus round =)

@domesticmouse domesticmouse merged commit 85575f6 into flutter:main Dec 4, 2024
10 checks passed
@domesticmouse domesticmouse deleted the add-flutter-gpu branch December 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwindmill ericwindmill ericwindmill approved these changes

@bdero bdero bdero approved these changes

@RedBrogdon RedBrogdon Awaiting requested review from RedBrogdon

@parlough parlough Awaiting requested review from parlough

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domesticmouse @bdero @ericwindmill