Skip to content

Conversation

@domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Effective Dart: Style recently, and have followed its advice.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse
Copy link
Contributor Author

Hey @miquelbeltran, if you have a half hour to check to make sure I haven't broken anything in your codelab, I'd be really appreciative. Thanks!

@miquelbeltran
Copy link
Member

Hey @miquelbeltran, if you have a half hour to check to make sure I haven't broken anything in your codelab, I'd be really appreciative. Thanks!

Hello! I'll take a look

@miquelbeltran miquelbeltran self-assigned this Dec 9, 2024
@miquelbeltran
Copy link
Member

@domesticmouse one thing I quickly noticed is that the code in in_app_purchases/complete has not been updated

@miquelbeltran miquelbeltran removed their assignment Dec 9, 2024
@miquelbeltran
Copy link
Member

With the changes I mentioned, I got the apps up and running. Let me know if you need anything else!

@domesticmouse
Copy link
Contributor Author

@domesticmouse one thing I quickly noticed is that the code in in_app_purchases/complete has not been updated

Thanks. I am curious about the status of the code in in_app_purchases/complete, it looks like it was the initial codebase that the steps were derived from, but it contains a bunch of debugging code not used elsewhere. Oh, and it adds a test. But it doesn't add any significant implementation...

@miquelbeltran
Copy link
Member

miquelbeltran commented Dec 9, 2024

Thanks. I am curious about the status of the code in in_app_purchases/complete, it looks like it was the initial codebase that the steps were derived from, but it contains a bunch of debugging code not used elsewhere. Oh, and it adds a test. But it doesn't add any significant implementation...

You are right. For what I can see, the complete existed before I took I over last year to implement the Dart Server.

I think I mostly used the complete to implement and test the solution, and then I went back to each step, so likely that it has more debug code left over.

@domesticmouse
Copy link
Contributor Author

Hey @miquelbeltran, any chance of an LGTM? +)

@domesticmouse domesticmouse merged commit 0bfb040 into flutter:main Dec 10, 2024
10 checks passed
@domesticmouse domesticmouse deleted the automate-in_app_purchases branch December 10, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants