Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspector V2 tests fail on latest Flutter #8582

Open
kenzieschmoll opened this issue Dec 2, 2024 · 1 comment
Open

Inspector V2 tests fail on latest Flutter #8582

kenzieschmoll opened this issue Dec 2, 2024 · 1 comment
Assignees
Labels
inspector-2.0-cleanup Bugs that will no longer be relevant after Inspector 2.0 has landed. P1 high priority issues at the top of the work list, actively being worked on. screen: inspector

Comments

@kenzieschmoll
Copy link
Member

https://github.com/flutter/devtools/actions/runs/12125339825/job/33805204667?pr=8580

This is likely due to flutter/flutter@21bea32 which changes how the inspector tree is populated.

Once this is fixed, the commit hash for the DevTools flutter customer test registry entries (flutter_devtools.test and flutter_devtools_analysis.test) for DevTools will need to be updated: https://github.com/flutter/tests/blob/main/registry/flutter_devtools.test

@kenzieschmoll kenzieschmoll added screen: inspector P1 high priority issues at the top of the work list, actively being worked on. inspector-2.0-cleanup Bugs that will no longer be relevant after Inspector 2.0 has landed. labels Dec 2, 2024
@kenzieschmoll
Copy link
Member Author

The failing test was skipped temporarily in #8580.

github-merge-queue bot pushed a commit to flutter/flutter that referenced this issue Dec 3, 2024
… `true` (#159701)

Work towards flutter/devtools#8582

Follow up to #159454

Only include the `truncated` field if it is `true`. We accidentally were
including it even when `false` which is what caused the regression in
the DevTools tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inspector-2.0-cleanup Bugs that will no longer be relevant after Inspector 2.0 has landed. P1 high priority issues at the top of the work list, actively being worked on. screen: inspector
Projects
None yet
Development

No branches or pull requests

2 participants