Add socket profiling to Network page #2191
Conversation
| static const _contentTypeKey = 'content-type'; | ||
| static const _cookieKey = 'cookie'; | ||
| static const _errorKey = 'error'; | ||
| static const _filterKey = 'filterKey'; |
There was a problem hiding this comment.
nit: normalize the key names. This one has the word Key in the value but others don't.
There was a problem hiding this comment.
filterKey is actually the name of the key in the arguments map. This would need to be changed on the VM but I think it is actually an accurate description as is because it is describing a key to group events on.
| static const _requestHeadersKey = 'requestHeaders'; | ||
| static const _responseHeadersKey = 'responseHeaders'; | ||
| static const _statusCodeKey = 'statusCode'; | ||
| static const _setCookieKey = 'set-cookie'; |
There was a problem hiding this comment.
perhaps add a TODO and file a bug upstream on the VM to cleanup the names.
There was a problem hiding this comment.
added a TODO and filed a bug. Names need to be changed upstream
| @@ -126,46 +131,68 @@ class NetworkController { | |||
| invalidRequests.add(requestData); | |||
| } | |||
| } | |||
| return HttpRequests( | |||
|
|
|||
| currentValues.removeWhere((value) => value is WebSocket); | |||
There was a problem hiding this comment.
nit: rather than removing all WebSocket, maybe just don't add them in the first place. it looks like we are adding them a couple lines earlier.
There was a problem hiding this comment.
At this point, currentValues contains all the current requests we have in the profiler, which will contain ws requests if they exist. When we refresh the network data after polling, the new data may contain web sockets with the same ids as ones we already have. For this reason, we need to remove the current web sockets and replace with the updated data in the profile. We could be smarter about this and keep unchanged sockets in the list if we need to.
There was a problem hiding this comment.
sg. can you add a comment to that effect?
|
Addresses part of #2044 |
This CL
Table with both HTTP and WS requests and overview for selected HTTP request:
Overview for socket:
TODO before submitting: add tests and general cleanup