Skip to content

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Nov 24, 2022

Fixes based on @anderdobo 's feedback.

@polina-c polina-c requested a review from a team as a code owner November 24, 2022 00:06
@polina-c polina-c requested review from kenzieschmoll and removed request for a team November 24, 2022 00:06
1. [Configure](https://docs.flutter.dev/get-started/install) Dart or Flutter.

2. In your terminal `cd` to a folder where you want to clone devtools, and that does not have subfolder `devtools` yet.
2. Install `jq`: `brew install jq`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not rather be Homebrew and GitHub CLI as prerequisites assumed for the commands to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub CLI is not required.
git is required, but it is installed out of the box on mac.
Homebrew is needed only as installer for jq

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need jq?

Copy link
Contributor Author

@polina-c polina-c Nov 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CANDIDATES=$(echo "$RESPONSE" | jq '.[].name' | grep candidate)

@polina-c polina-c merged commit 019614f into master Nov 29, 2022
@polina-c polina-c deleted the polina-c-patch-2 branch November 29, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants