Add initial support for non-query param navigation state #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for providing additional state when navigating through DevTools via `DevToolsRouterDelegate` without polluting the query parameters with extra entries. This state is included in the navigation history. Controllers can mixin the new `RouteStateHandlerMixin` and override `onRouteStateUpdate(DevToolsNavigationState)` to handle changes in the current DevTools navigation state. To handle state changes, `subscribeToRouterEvents` must first be called on the controller. This change also adds support for jumping to a source location in the debugger from URIs in the CPU profiler.
bkonyi
requested review from
a team,
elliette and
kenzieschmoll
as code owners
packages/devtools_app/lib/src/screens/debugger/codeview_controller.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
approved these changes
Dec 7, 2022
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
One more comment then LGTM. Can you also add a TODO and file an issue to add an integration test that uses the chrome back / forward buttons once we can run integration tests?
elliette
approved these changes
Dec 7, 2022
Member
elliette
left a comment
elliette
left a comment
There was a problem hiding this comment.
LGTM for debugger screen changes!
Contributor
Author
|
Filed #4902 for future integration testing. |
Merged
CoderDake
pushed a commit
that referenced
this pull request
Dec 9, 2022
This change adds support for providing additional state when navigating through DevTools via `DevToolsRouterDelegate` without polluting the query parameters with extra entries. This state is included in the navigation history. Controllers can mixin the new `RouteStateHandlerMixin` and override `onRouteStateUpdate(DevToolsNavigationState)` to handle changes in the current DevTools navigation state. To handle state changes, `subscribeToRouterEvents` must first be called on the controller. This change also adds support for jumping to a source location in the debugger from URIs in the CPU profiler.
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for providing additional state when navigating through DevTools via
DevToolsRouterDelegatewithout polluting the query parameters with extra entries. This state is included in the navigation history.Controllers can mixin the new
RouteStateHandlerMixinand overrideonRouteStateUpdate(DevToolsNavigationState)to handle changes in the current DevTools navigation state. To handle state changes,subscribeToRouterEventsmust first be called on the controller.This change also adds support for jumping to a source location in the debugger from URIs in the CPU profiler.