Skip to content

Disable experiments for debug and profile mode. #4861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Disable experiments for debug and profile mode. #4861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions packages/devtools_app/lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:flutter_riverpod/flutter_riverpod.dart';

Expand All @@ -15,7 +14,6 @@ import 'src/config_specific/url_strategy/url_strategy.dart';
import 'src/extension_points/extensions_base.dart';
import 'src/extension_points/extensions_external.dart';
import 'src/framework/app_error_handling.dart';
import 'src/primitives/feature_flags.dart';
import 'src/primitives/url_utils.dart';
import 'src/screens/debugger/syntax_highlighter.dart';
import 'src/screens/provider/riverpod_error_logger_observer.dart';
Expand Down Expand Up @@ -47,11 +45,6 @@ void main() async {
await SyntaxHighlighter.initialize();

setupErrorHandling(() async {
// Experiments are enabled here,
// not at initialization, because
// [enableExperiments] should be false for tests.
if (!kReleaseMode) setExperimentsEnabled();

// Run the app.
runApp(
ProviderScope(
Expand Down
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/primitives/feature_flags.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const bool _kEnableExperiments = bool.fromEnvironment('enable_experiments');

@visibleForTesting
bool enableExperiments = _kEnableExperiments;
void setExperimentsEnabled() => enableExperiments = true;

@visibleForTesting
bool get enableBeta => enableExperiments || !isExternalBuild;
Expand Down