Integrate leak_tracker. #4891
Merged
Integrate leak_tracker. #4891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
reviewed
Dec 7, 2022
packages/devtools_app/lib/src/screens/memory/panes/leaks/controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/leaks/controller.dart
Outdated
Show resolved
Hide resolved
| final message = EventFromApp.fromVmServiceEvent(vmServiceEvent)?.message; | ||
| if (message == null) return; | ||
|
|
||
| if (message is LeakTrackingStarted) { |
Contributor
There was a problem hiding this comment.
Nit: maybe change this to use a switch statement instead?
if (message == null) return;
switch(message.runtimeType) {
case LeakTrackingStarted:
...
case LeakSummary:
...
default:
throw StateError('...');
}
Contributor
Author
There was a problem hiding this comment.
Will do this as patterns get released. For now there is no type promotion for 'runtimeType':
Contributor
There was a problem hiding this comment.
Ah good point. Waiting for patterns SGTM.
packages/devtools_app/lib/src/screens/memory/panes/leaks/controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/leaks/controller.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/lib/src/screens/memory/panes/leaks/primitives/simple_items.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/memory/leaks/diagnostics/leak_analyzer_test.dart
Outdated
Show resolved
Hide resolved
bkonyi
approved these changes
Dec 7, 2022
CoderDake
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See UX in description of dart-lang/leak_tracker#20