Skip to content

Reorganize code - 2. #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2022
Merged

Reorganize code - 2. #4909

merged 3 commits into from
Dec 8, 2022

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 8, 2022 •
edited
Loading

  1. Update README for shared and primitives.
  2. Move feature_flags.dart out of primitives.
  3. Merge auto_dispose.dart and auto_dispose_mixin.dart.

kenzieschmoll
kenzieschmoll reviewed Dec 8, 2022
View reviewed changes
packages/devtools_app/lib/devtools_app.dart Outdated
export 'src/shared/preferences.dart';
export 'src/shared/primitives/auto_dispose.dart';
export 'src/shared/primitives/auto_dispose_mixin.dart';
export 'src/shared/primitives/auto_dispose.dart';
Copy link
Member

@kenzieschmoll kenzieschmoll Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double import

Copy link
Contributor Author

@polina-c polina-c Dec 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executed dart fix --apply

@polina-c polina-c marked this pull request as ready for review December 8, 2022 19:18
@polina-c polina-c requested review from a team, CoderDake, bkonyi and elliette as code owners December 8, 2022 19:18
@polina-c polina-c merged commit e4bba5d into flutter:master Dec 8, 2022
@polina-c polina-c deleted the reorg2 branch December 8, 2022 19:55
@CoderDake CoderDake mentioned this pull request Dec 22, 2022
Closed
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenzieschmoll kenzieschmoll kenzieschmoll approved these changes

@bkonyi bkonyi Awaiting requested review from bkonyi bkonyi is a code owner

@elliette elliette Awaiting requested review from elliette elliette is a code owner

@CoderDake CoderDake Awaiting requested review from CoderDake

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polina-c @kenzieschmoll