Scroll flutter frames chart to selected frame on first load #4930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
commented
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Show resolved
Hide resolved
kenzieschmoll
commented
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Show resolved
Hide resolved
kenzieschmoll
commented
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
commented
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Outdated
Show resolved
Hide resolved
kenzieschmoll
commented
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Show resolved
Hide resolved
polina-c
reviewed
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Outdated
Show resolved
Hide resolved
polina-c
reviewed
Dec 10, 2022
...ages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frames_chart.dart
Outdated
Show resolved
Hide resolved
polina-c
approved these changes
Dec 10, 2022
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4873
This required some refactoring to convert the
_buildChartmethod into a stateful widget FramesChart. There are a lot of moves here, I will comment on the new lines of code.