Skip to content

UX improvements for diff. #4958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 16, 2022
Merged

UX improvements for diff. #4958

merged 8 commits into from
Dec 16, 2022

Conversation

@polina-c
Copy link
Contributor

@polina-c polina-c commented Dec 16, 2022 •
edited
Loading

  1. Stop showing root
  2. Show total size of snapshot
  3. Show % of total for retained size of single view
  4. Make test white for selected snapshot

Fixes #4794
Fixes #4796

Before:
Screenshot 2022-12-16 at 3 10 44 PM

After:
Screenshot 2022-12-16 at 3 16 15 PM

@polina-c polina-c marked this pull request as ready for review December 16, 2022 21:57
@polina-c polina-c requested a review from a team as a code owner December 16, 2022 21:57
@polina-c polina-c requested review from kenzieschmoll and removed request for a team December 16, 2022 21:57
@polina-c polina-c merged commit 21367bd into flutter:master Dec 16, 2022
@polina-c polina-c deleted the show-percents branch December 16, 2022 22:10
@CoderDake CoderDake mentioned this pull request Dec 22, 2022
Closed
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bkonyi bkonyi bkonyi approved these changes

@kenzieschmoll kenzieschmoll Awaiting requested review from kenzieschmoll kenzieschmoll is a code owner automatically assigned from flutter/devtools-reviewers

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show percentage for Retained size in single snapshot view in Memory > Diff pane Hide Root in Diff pane

2 participants

@polina-c @bkonyi