Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Dart file locations in the stacktraces for errors #8385

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

elliette
Copy link
Member

@elliette elliette commented Oct 1, 2024

Fixes #7392

This PR:

  • Includes source maps for dart2js and dart2wasm builds of DevTools
  • When reporting an error to the user and Google Analytics, uses the mapped stack trace instead of the minified stack trace
  • Programmatically determines whether to use the JS source map or wasm source map based on whether the wasm experiment is enabled

dart2js mapped stacktrace:
Screenshot 2024-10-01 at 2 11 57 PM

dart2wasm mapped stacktrace:
Screenshot 2024-10-01 at 3 46 57 PM

@elliette elliette requested review from kenzieschmoll and a team as code owners October 1, 2024 23:22
Copy link
Member Author

@elliette elliette Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest candidate in g3. It contains flutter/flutter#155846 which is required so that we can pull in the latest version of package:stack_trace

Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you for working on this! Would be a bonus at some point if some of this logic could get upstreamed into a dart package so all Flutter web apps could have an easy way to handle source mapping.

@elliette elliette merged commit 15f8030 into flutter:master Oct 2, 2024
23 checks passed
@kenzieschmoll kenzieschmoll mentioned this pull request Oct 2, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get stacktrace information in release build of DevTools
2 participants