Skip to content

Commit

Permalink
Review Changes
Browse files Browse the repository at this point in the history
  • Loading branch information
gspencergoog committed Mar 1, 2023
1 parent a82f1cd commit 1bd9d6f
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 12 deletions.
13 changes: 7 additions & 6 deletions lib/ui/platform_dispatcher.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1736,9 +1736,9 @@ enum AppLifecycleState {
/// The possible responses to a request to exit the application.
///
/// The request is typically responded to by a [WidgetsBindingObserver].
// TODO(gspencergoog): Insert references here to AppLifecycleListener and to the
// actual function called on WidgetsBindingObserver once those have landed in
// the framework.
// TODO(gspencergoog): Insert doc references here to AppLifecycleListener and to
// the actual function called on WidgetsBindingObserver once those have landed
// in the framework. https://github.com/flutter/flutter/issues/121721
enum AppExitResponse {
/// Exiting the application can proceed.
exit,
Expand All @@ -1748,13 +1748,14 @@ enum AppExitResponse {

/// The type of application exit to perform when calling
/// `ServicesBinding.exitApplication`.
// TODO(gspencergoog): Insert references here to ServicesBinding.exitApplication
// that has landed in the framework.
// TODO(gspencergoog): Insert doc references here to
// ServicesBinding.exitApplication that has landed in the framework.
// https://github.com/flutter/flutter/issues/121721
enum AppExitType {
/// Requests that the application start an orderly exit, sending a request
/// back to the framework through the [WidgetsBinding], and if that responds
/// with [AppExitResponse.exit], then proceed with the same steps as a
/// [required] exit. if that responds with [AppExitResponse.cancel], then the
/// [required] exit. If that responds with [AppExitResponse.cancel], then the
/// exit request is canceled and the application continues executing normally.
cancelable,

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
* application: that is left up to the engine, which will call this function if
* it decides that termination request is granted, which will start the regular
* Cocoa flow for terminating the application, calling
* |applicationShouldTermnate|, etc.
* |applicationShouldTerminate|, etc.
*
* @param(sender) The id of the object requesting the termination, or nil.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ - (NSString*)applicationName;

@implementation FlutterAppDelegate

// TODO(stuartmorgan): Implement application lifecycle forwarding to plugins here, as is done
// TODO(gspencergoog): Implement application lifecycle forwarding to plugins here, as is done
// on iOS. Currently macOS plugins don't have access to lifecycle messages.
// https://github.com/flutter/flutter/issues/30735

- (instancetype)init {
if (self = [super init]) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
// found in the LICENSE file.

#import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterEngine.h"
#include "FlutterCodecs.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine_Internal.h"

#include <algorithm>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,17 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "OCMock/OCMArg.h"
#include "OCMock/OCMock.h"
#import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterEngine.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterEngine_Internal.h"
#include "gtest/gtest.h"
#include "shell/platform/darwin/macos/framework/Headers/FlutterApplication.h"

#include <functional>
#include <thread>

#include "flutter/fml/synchronization/waitable_event.h"
#include "flutter/lib/ui/window/platform_message.h"
#include "flutter/shell/platform/common/accessibility_bridge.h"
#import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterApplication.h"
#import "flutter/shell/platform/darwin/macos/framework/Headers/FlutterAppDelegate.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterEngineTestUtils.h"
#import "flutter/shell/platform/darwin/macos/framework/Source/FlutterViewControllerTestUtils.h"
Expand Down

0 comments on commit 1bd9d6f

Please sign in to comment.