This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Commit 72569a6
authored
[Android] Fix Slider semantics double tap behaviors (#56452)
## Description
Android fix for [[A11y] Double Tap brings the Slider thumb to the center of the widget.](flutter/flutter#156427). Similar to [the iOS engine fix](#56427).
Slider widget doesn't define a Semantics.onTap handler, so a double-click while in accessibility mode defaults to a regular tap down event to which _RenderSlider reacts by changing the slider value.
Adding a onTap callback on the framework side was tried in flutter/flutter#157601 but it breaks one accessibility guideline test, see flutter/flutter#157601 (comment)).
See flutter/flutter#157601 (comment) for the reasoning to make the change at the engine level.
## Related Issue
Android fix for [[A11y] Double Tap brings the Slider thumb to the center of the widget.](flutter/flutter#156427).
## Tests
Adds 1 test.1 parent cc3574f commit 72569a6
File tree
2 files changed
+24
-0
lines changed- shell/platform/android
- io/flutter/view
- test/io/flutter/view
2 files changed
+24
-0
lines changedLines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
802 | 802 | | |
803 | 803 | | |
804 | 804 | | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
805 | 814 | | |
806 | 815 | | |
807 | 816 | | |
| |||
Lines changed: 15 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2165 | 2165 | | |
2166 | 2166 | | |
2167 | 2167 | | |
| 2168 | + | |
| 2169 | + | |
| 2170 | + | |
| 2171 | + | |
| 2172 | + | |
| 2173 | + | |
| 2174 | + | |
| 2175 | + | |
| 2176 | + | |
| 2177 | + | |
| 2178 | + | |
| 2179 | + | |
| 2180 | + | |
| 2181 | + | |
| 2182 | + | |
2168 | 2183 | | |
2169 | 2184 | | |
2170 | 2185 | | |
| |||
0 commit comments