Skip to content

Commit

Permalink
[VM] Fix for issue 34839 - Dart_Cleanup may hang while shutting down
Browse files Browse the repository at this point in the history
     the service isolate.

     The service isolate request for shutdown uses a Dart level message
     for exiting the isolate, this shuts down the isolate but does not
     completely bring the isolate down if there are some open ports. We
     have a timer isolate started in the VM isolate and if the shutdown
     happens soon enough this port is still open.

Change-Id: Icfa07c91b8692eb76ba8502063cf6f5cf04832a5
Reviewed-on: https://dart-review.googlesource.com/c/81200
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
  • Loading branch information
a-siva authored and commit-bot@chromium.org committed Oct 23, 2018
1 parent e648d63 commit 89c845e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions runtime/lib/vmservice.cc
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ DEFINE_NATIVE_ENTRY(VMService_OnExit, 0) {
OS::PrintErr("vm-service: live ports = %" Pd "\n",
message_handler->live_ports());
}
Isolate::KillIfExists(isolate, Isolate::kInternalKillMsg);
return Object::null();
}

Expand Down

0 comments on commit 89c845e

Please sign in to comment.