Fix buildbots by not adding unsupported flags when building on Mac. (#…

…185)
flutter · Oct 27, 2018 · 8b75164 · 8b75164
1 parent 58c5b8d
commit 8b75164
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
@@ -415,9 +415,12 @@ config("compiler") {
       "-funwind-tables",
       "-fno-short-enums",
       "-nostdinc++",
-      "-Wa,--noexecstack",
+
+      # TODO(kf6gpe): -Wa,--noexecstack is not supported by the Mac toolchain
+      # with targeting Android. https://github.com/flutter/flutter/issues/23606
+      # "-Wa,--noexecstack",
       "-Wformat",
-      "-Wformat-security"
+      "-Wformat-security",
     ]
     if (!is_clang) {
       # Clang doesn't support these flags.