-
Notifications
You must be signed in to change notification settings - Fork 6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Improve degenerate 2pt conical gradient cases"
This reverts commit 879dab8. Reason for revert: Android roll failed. https://sponge.corp.google.com/target?id=93bc6b8d-9b42-4805-b204-46ae62f1b005&target=x86+CtsGraphicsTestCases&searchFor=&show=FAILED&sortBy=STATUS A test VectorDrawableTest.testVectorDrawableGradient fails. Original change's description: > Improve degenerate 2pt conical gradient cases > > This was originally a reland of "Fix div-by-zero loophole in gradient factory func", c34dd6c, but: > > The change caused blink layout tests when encountering very small or zero radii. The original patch switched the order of checking if the radii are equal and if the start radius was 0. In the case where both radii are 0, the original code created an actual radial gradient of radius 0 and the new code rejected the shader. A radial gradient with radius of 0 properly renders the last border color as a fill. > > This made me realize that the case when the center positions and the radii are the same can be handled more correctly than just always returning an empty shader, so the fix now applies simplifications to the gradient definition depending on the tile mode and should not trigger any blink tests. I added a row to the gradient edge cases GM to make sure it degrades gracefully. > > Original change's description: > > Fix div-by-zero loophole in gradient factory func > > > > Bug: oss-fuzz:10373 > > Change-Id: I4277fb63e3186ee34feaf09ecf6aeddeb532f9c1 > > Reviewed-on: https://skia-review.googlesource.com/c/168269 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Michael Ludwig <michaelludwig@google.com> > > Docs-Preview: https://skia.org/?cl=168487 > Bug: oss-fuzz:10373 > Change-Id: Ib0a6e7f807560a5dcf24d1c8e0146817af2d9606 > Reviewed-on: https://skia-review.googlesource.com/c/168487 > Reviewed-by: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> TBR=caryclark@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,michaelludwig@google.com Change-Id: I91b896c4a438c02206679b327a01b47f40993965 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: oss-fuzz:10373 Reviewed-on: https://skia-review.googlesource.com/c/170272 Reviewed-by: Stan Iliev <stani@google.com> Commit-Queue: Stan Iliev <stani@google.com>
Showing
5 changed files
with
13 additions
and
313 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters