Do not log unwind errors during isolate shutdown (#6008)

flutter · Aug 13, 2018 · 9d47106 · 9d47106
1 parent 89176ee
commit 9d47106
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/runtime/dart_isolate.cc b/runtime/dart_isolate.cc
@@ -808,10 +808,12 @@ void DartIsolate::DartIsolateShutdownCallback(
   }
 
   tonic::DartApiScope api_scope;
-  FML_LOG(ERROR) << "Isolate " << tonic::StdStringFromDart(Dart_DebugName())
-                 << " exited with an error";
   Dart_Handle sticky_error = Dart_GetStickyError();
-  FML_CHECK(tonic::LogIfError(sticky_error));
+  if (!Dart_IsFatalError(sticky_error)) {
+    FML_LOG(ERROR) << "Isolate " << tonic::StdStringFromDart(Dart_DebugName())
+                   << " exited with an error";
+    FML_CHECK(tonic::LogIfError(sticky_error));
+  }
 }
 
 // |Dart_IsolateCleanupCallback|