Skip to content

Commit

Permalink
Declare flutter_gdb as a Python 2 script (#28138)
Browse files Browse the repository at this point in the history
The script has not been ported to Python 3.  The environment required by
Python 3 (e.g. PYTHONHOME) may conflict with the environment expected by
the Python 2 runtime linked into the version of GDB launched by the script.
  • Loading branch information
jason-simmons authored Aug 18, 2021
1 parent 0591aba commit b13c765
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 6 deletions.
4 changes: 1 addition & 3 deletions ci/licenses_golden/licenses_skia
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Signature: 84d0a762b7ddb7d5817405df71c998dc
Signature: 29d7ebca3e5cdc5e122f260a9ade4964

UNUSED LICENSES:

Expand Down Expand Up @@ -3346,8 +3346,6 @@ FILE: ../../../third_party/skia/bench/ClipMaskBench.cpp
FILE: ../../../third_party/skia/bench/ClipStrategyBench.cpp
FILE: ../../../third_party/skia/bench/PathTextBench.cpp
FILE: ../../../third_party/skia/bench/ShadowBench.cpp
FILE: ../../../third_party/skia/bin/gerrit-number
FILE: ../../../third_party/skia/bin/sysopen
FILE: ../../../third_party/skia/dm/DMGpuTestProcs.cpp
FILE: ../../../third_party/skia/example/HelloWorld.cpp
FILE: ../../../third_party/skia/example/HelloWorld.h
Expand Down
2 changes: 1 addition & 1 deletion ci/licenses_golden/tool_signature
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Signature: ba62ed10d5e046f90a397663d6c9d5d2
Signature: 2b08c736bc3af2c5d770099c53112c83

2 changes: 1 addition & 1 deletion sky/tools/flutter_gdb
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env python3
#!/usr/bin/env python2
#
# Copyright 2013 The Flutter Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
Expand Down
2 changes: 1 addition & 1 deletion tools/licenses/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class _RepositorySourceFile extends _RepositoryLicensedFile {

fs.TextFile get ioTextFile => super.io as fs.TextFile;

static final RegExp _hashBangPattern = RegExp(r'^#! *(?:/bin/sh|/bin/bash|/usr/bin/env +(?:python|python3|bash))\b');
static final RegExp _hashBangPattern = RegExp(r'^#! *(?:/bin/sh|/bin/bash|/usr/bin/env +(?:python[23]?|bash))\b');

@override
bool get isShellScript {
Expand Down

0 comments on commit b13c765

Please sign in to comment.