Update tests for const constructors in subclasses of mixin applications

Change-Id: I6203256f8fc4ff4ef7312ec95dcd23ab99e5d54c Reviewed-on: https://dart-review.googlesource.com/68663 Reviewed-by: Erik Ernst <eernst@google.com> Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
flutter · Aug 7, 2018 · d933d4a · d933d4a
1 parent b570ea1
commit d933d4a
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/tests/language_2/const_constructor_mixin3_test.dart b/tests/language_2/const_constructor_mixin3_test.dart
@@ -8,9 +8,7 @@ class A {
   const A();
 }
 
-class B extends A
-    with Mixin //# 01: compile-time error
-{
+class B extends A with Mixin {
   const B();
 }
 

diff --git a/tests/language_2/const_constructor_mixin_test.dart b/tests/language_2/const_constructor_mixin_test.dart
@@ -8,9 +8,7 @@ class A {
   const A(foo);
 }
 
-class B extends A
-    with Mixin //# 01: compile-time error
-{
+class B extends A with Mixin {
   const B(foo) : super(foo);
 }
 

diff --git a/tests/language_2/language_2_analyzer.status b/tests/language_2/language_2_analyzer.status
@@ -44,8 +44,6 @@ config_import_corelib_test: StaticWarning, OK
 conflicting_type_variable_and_setter_test: CompileTimeError # Issue 25525
 const_cast2_test/01: CompileTimeError
 const_cast2_test/none: CompileTimeError
-const_constructor_mixin3_test/01: MissingCompileTimeError # Issue 33644
-const_constructor_mixin_test/01: MissingCompileTimeError # Issue 33644
 const_for_in_variable_test/01: MissingCompileTimeError # Issue 25161
 dynamic_prefix_core_test/01: MissingCompileTimeError
 emit_const_fields_test: CompileTimeError

diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status
@@ -21,6 +21,8 @@ checked_setter2_test: RuntimeError # Issue 31128
 checked_setter_test: RuntimeError # Issue 31128
 config_import_corelib_test: CompileTimeError # we need a special platform.dill file for categories=all. Once we fix that, all dart:* are supported when using '--categories=all' so this will become a RuntimeError, OK.
 config_import_test: RuntimeError # Test flag is not passed to the compiler.
+const_constructor_mixin3_test: CompileTimeError # Issue 33644.
+const_constructor_mixin_test: CompileTimeError # Issue 33644.
 const_constructor_nonconst_param_test/01: MissingCompileTimeError
 const_dynamic_type_literal_test/03: Pass # but it shouldn't until we fix issue 17207
 deopt_inlined_function_lazy_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351

diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status
@@ -234,6 +234,8 @@ conditional_import_test: CompileTimeError # Test is broken
 config_import_test: CompileTimeError
 const_cast1_test/02: MissingCompileTimeError
 const_constructor3_test/04: MissingCompileTimeError
+const_constructor_mixin3_test: CompileTimeError # Issue 33644.
+const_constructor_mixin_test: CompileTimeError # Issue 33644.
 const_constructor_nonconst_field_test/01: MissingCompileTimeError
 const_constructor_nonconst_param_test/01: MissingCompileTimeError
 const_dynamic_type_literal_test/02: MissingCompileTimeError

diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status
@@ -222,6 +222,8 @@ call_non_method_field_test/01: MissingCompileTimeError # Issue 32975
 call_non_method_field_test/02: MissingCompileTimeError # Issue 32975
 const_cast2_test/01: CompileTimeError # Issue 32517
 const_cast2_test/none: CompileTimeError # Issue 32517
+const_constructor_mixin3_test: CompileTimeError # Issue 33644.
+const_constructor_mixin_test: CompileTimeError # Issue 33644.
 const_instance_field_test/01: MissingCompileTimeError # Fasta bug: Const instance field. Issue 32326.
 const_types_test/34: MissingCompileTimeError # Issue 32988
 const_types_test/39: MissingCompileTimeError # Issue 32988
@@ -1385,6 +1387,8 @@ conditional_import_string_test: CompileTimeError # KernelVM bug: Deferred loadin
 conditional_import_test: CompileTimeError # KernelVM bug: Deferred loading kernel issue 30273.
 config_import_corelib_test: CompileTimeError # Issue 31533
 config_import_test: RuntimeError # KernelVM bug: Configurable imports.
+const_constructor_mixin3_test: CompileTimeError # Issue 33644.
+const_constructor_mixin_test: CompileTimeError # Issue 33644.
 const_dynamic_type_literal_test/02: RuntimeError # KernelVM bug: Constant map duplicated key.
 const_list_test: RuntimeError
 const_locals_test: RuntimeError